spv: Implement per-peer increasing backoffs #2466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to also add last attempt tracking, so that when we return to a discovered peer at a later point which already had a backoff chosen, we won't wait for the full backoff duration at the point the peer is chosen again, but only the remaining time (if any). |
jrick
force-pushed
the
spvbackoff
branch
2 times, most recently
from
8d278b7 to
2d7ec6d
Compare
JoeGruffins
reviewed
Jan 28, 2025
|
Unsure if it's the exact same case you saw, but when I kill my connections while it is in the middle of the rescan, it never errors out of it, and that seems to hang the whole thing. Will take a closer look in the morning. |
|
Fixed. It wasn't actually hung, just sleeping for a stupidly long timeout. |
During clean shutdown, signal the mixing client to shutdown first, waiting for it to finish running, before closing the RPC and SPV syncers. Updates the mixing module to a version that supports continuing active mixes before terminating the mixing client.
Recreate a new syncer in the SPV reconnect loop in main. This will allow initial sync logic to be reperformed if peers can be connected later. This also adds a forced 5s backoff before peers connection attempts are made again, matching the backoff behavior for RPC syncing.
Backoff for discovered peers begins at 5s and adds an exponentially-decaying increase before maxing out at 90s. Persistent peers use a smaller scaled backoff curve starting at 1s and maxing out at 18s). All backoffs include a small amount of random jitter to avoid reconnection storms at syncer startup. Backoffs are reset if network connection is established to the peer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backoff for discovered peers begins at 5s and adds an exponentially-decaying
increase before maxing out at 90s. Persistent peers use a smaller scaled
backoff curve starting at 1s and maxing out at 18s).
All backoffs include a small amount of random jitter to avoid reconnection
storms at syncer startup.
Backoffs are reset if network connection is established to the peer.
Rebased over #2465.