Remove duplicated and unused ticketbuyer config options. #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
Jan 3, 2017
| case ticketbuyer.TicketFeeMedian: | ||
| default: | ||
| str := "%s: Invalid fee source '%s'" | ||
| err := fmt.Errorf(str, "loadTicketBuyerConfig", cfg.TBOpts.FeeSource) |
There was a problem hiding this comment.
if this is supposed to be the function name of the caller, it's not right.
jrick
reviewed
Jan 3, 2017
| case ticketbuyer.PriceTargetDual: | ||
| default: | ||
| str := "%s: Invalid average price mode '%s'" | ||
| err := fmt.Errorf(str, "loadTicketBuyerConfig", cfg.TBOpts.AvgPriceMode) |
|
Looks good, only thing I think is missing is to add a warning when the old ticketbuyer config is still found. We should inform the user about this so if they haven't yet, they know to migrate their settings over into the wallet config and remove the old file. |
jrick
changed the title
The ticketbuyer configuration now lives in the main configuration file under the [Ticket Buyer Options] section.
jrick
approved these changes
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467