[redesign] Trezor views #3570
Merged
[redesign] Trezor views #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgptr
force-pushed
the
trezor-redesign
branch
2 times, most recently
from
160b657 to
e880215
Compare
bgptr
force-pushed
the
trezor-redesign
branch
from
e880215 to
5ae13b3
Compare
bgptr
force-pushed
the
trezor-redesign
branch
from
5ae13b3 to
6e09a1b
Compare
bgptr
force-pushed
the
trezor-redesign
branch
from
76a32ba to
7c7915e
Compare
bgptr
force-pushed
the
trezor-redesign
branch
from
7c7915e to
da7ab09
Compare
bgptr
force-pushed
the
trezor-redesign
branch
2 times, most recently
from
b04ed61 to
15b1adb
Compare
…fig page - introduce TrezorPageSection. Use accordion in the getstarted section and simple title and container inside the app - update trezorPageAccordation's style - toggle pin protection - toggle passphrase and on device - rename ConfigButtons to SecuritySection
bgptr
force-pushed
the
trezor-redesign
branch
from
90ab7fb to
264c3ac
Compare
|
@matheusd When you have some time it would be great if you could take a look at this diff. Changes and code looks solid but I don't currently have the ability to fully test all of the Trezor bits. |
matheusd
reviewed
Nov 21, 2022
matheusd
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
LGTM (tested on model one and model T emulators)
Small nits, that are not show stoppers:
- Sending a tx doesn't seem to be triggering notifications anymore (not sure it's related to this PR)
- When restoring a model one and typing the seed words, the input focus is lost between words, so you need to click again in the input box after every word
|
Opened a new issue for these nits in #3835 |
alexlyp
pushed a commit
that referenced
this pull request
Apr 6, 2023
- introduce TrezorPageSection. Use accordion in the getstarted section and simple title and container inside the app - update trezorPageAccordation's style - toggle pin protection - toggle passphrase and on device - rename ConfigButtons to SecuritySection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward issue #3297
Requires decred/pi-ui#410 (merged)
This diff implements the updated Trezor views in #3297.
On Wallet Selection view - as an only change - a
Create a Trezor-backed Walletbutton has been added.Tested on a physical Trezor One device and Trezor Modal T simulator.
Also added automated tests for the trezor views.
Screenshots: