Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: Enable mainnet. #3906

Merged
merged 1 commit into from
Sep 26, 2023
Merged

ledger: Enable mainnet. #3906

merged 1 commit into from
Sep 26, 2023

Conversation

JoeGruffins
Copy link
Member

@JoeGruffins JoeGruffins commented Sep 21, 2023

Depends on #3874
closes #3865

@JoeGruffins
Copy link
Member Author

@matheusd let me know if we need anything else to enable here, besides testing this

I am testing on mainnet on linux and windows with nano x and nano s plus. I believe @amass01 is testing on mac? Thanks all for your support almost done, hopefully.

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on mainnet, on both Linux and Windows with a Nano-S. I also tested recovery using software only, by using my bip39-to-dcr-seed tool. Nice work!

@amass01
Copy link
Member

amass01 commented Sep 24, 2023

dále, i will test on m1 mac today 🙏🏽

@JoeGruffins JoeGruffins marked this pull request as ready for review September 26, 2023 07:39
Comment on lines +161 to +163
.catch((e) => {
throw e;
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant, it will be thrown by default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, will keep this in mind and fix at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was mac alright?

@alexlyp alexlyp merged commit f8447b2 into decred:master Sep 26, 2023
alexlyp pushed a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi: Add Ledger support.
4 participants