Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] Make value and onChange props required #430

Closed
tiagoalvesdulce opened this issue Mar 28, 2022 · 0 comments · Fixed by #437
Closed

[DatePicker] Make value and onChange props required #430

tiagoalvesdulce opened this issue Mar 28, 2022 · 0 comments · Fixed by #437
Assignees
@tiagoalvesdulce

Comments

@tiagoalvesdulce
Copy link
Member

The uncontrolled version of our DatePicker is very buggy and not very useful. I think those two props should be required so the component is always controlled.
@tiagoalvesdulce tiagoalvesdulce changed the title [DatePicker] Make value and onChange required [DatePicker] Make value and onChange props required Mar 28, 2022
@tiagoalvesdulce tiagoalvesdulce self-assigned this Apr 7, 2022
@tiagoalvesdulce tiagoalvesdulce mentioned this issue Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiagoalvesdulce tiagoalvesdulce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(DatePicker): make onChange and value required tiagoalvesdulce/pi-ui
1 participant
@tiagoalvesdulce