feat(DatePicker): make onChange and value required #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
changed the title
victorgcramos
requested changes
Apr 7, 2022
Comment on lines
396
to
397
| (fn.prototype.constructor.length < 2 && | ||
| fn.prototype.constructor.length > 3) |
There was a problem hiding this comment.
I think the operator here is || 😁
| onChange: function (props, propName) { | ||
| var fn = props[propName]; | ||
| if ( | ||
| !fn.prototype || |
There was a problem hiding this comment.
when onChange is null or undefined, the error message is:
Warning: Failed prop type: Cannot read properties of undefined (reading 'prototype')
I think we should also display the ... must be a function with 2 (if isMonthsMode is on) or 3 args. Args are: year, month and day. error.
There was a problem hiding this comment.
Yeah, will add that. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430