Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select component #227

Merged
merged 9 commits into from
Mar 13, 2020
Merged

Select component #227

merged 9 commits into from
Mar 13, 2020

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Mar 7, 2020

Migrated from pigui code.
closes #207

@amass01 amass01 mentioned this pull request Mar 7, 2020
Merged
victorgcramos
victorgcramos requested changes Mar 10, 2020
View reviewed changes
Copy link
Member

@victorgcramos victorgcramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just need to fix the select's width and it should be good to go!

Running on Firefox Developer Edition v74.0b9
Screen Shot 2020-03-10 at 17 33 32

@amass01 amass01 requested a review from tiagoalvesdulce March 13, 2020 16:04
victorgcramos
victorgcramos approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@victorgcramos victorgcramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job@

@tiagoalvesdulce tiagoalvesdulce merged commit 35a76e1 into decred:master Mar 13, 2020
@amass01 amass01 deleted the selectComp branch March 28, 2020 20:33
@bgptr bgptr mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorgcramos victorgcramos victorgcramos approved these changes

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select component
3 participants
@amass01 @tiagoalvesdulce @victorgcramos