docs: drop docz and rewrite docs with storybook #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoalvesdulce
changed the title
victorgcramos
requested changes
Mar 30, 2022
There was a problem hiding this comment.
Looking really good. Storybook is a great alternative and it's very intuitive, customizable and clean.
While reviewing it, I noticed the following:
-
Editing the
errorfield on inputs throws an error:
-
It would be nice if you add the text editing commands from feat(Icon): text formatting icons #429
-
Can you make Icon
typefield a selector with all available types? -
Editing the
hoverTextfield on CopyableText throws an error:
|
1 and 4 are because the proptype is a 2 and 3. I already opened an issue: #431. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had enough issues with docz... This PR will drop it for good! The documentation will be re-written with Storybook
Closes #425
Here is a small example:
new_doc.mp4