Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ButtonIcon Tooltip #438

Merged
merged 3 commits into from
Apr 11, 2022
Merged

feat: Add ButtonIcon Tooltip #438

merged 3 commits into from
Apr 11, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Apr 7, 2022 •
edited
Loading

Closes #423

This diff adds an optional tooltip for ButtonIcon.

Usage

<ButtonIcon
  type="create"
  tooltipText="Create a New Wallet"
  tooltipPlacement="bottom"
/>

Preview

Screen Shot 2022-04-07 at 12 45 24 PM

tiagoalvesdulce
tiagoalvesdulce approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left a few inline comments.

src/components/ButtonIcon/ButtonIcon.jsx Outdated Show resolved Hide resolved
src/components/ButtonIcon/ButtonIcon.jsx Show resolved Hide resolved
src/components/Tooltip/Tooltip.jsx Show resolved Hide resolved
tiagoalvesdulce
tiagoalvesdulce approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit 6b219c9 into decred:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button Icon optional Tooltip
2 participants
@victorgcramos @tiagoalvesdulce