-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: Add Proposal New page #2751
multi: Add Proposal New page #2751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I like the improved design. A few comments:
- The info tooltips for the RFP Tokens and RFP Deadlines are missing.
- Tab navigation can be improved. Ideally we should be able to navigate through the page with the Keyboard (https://webaim.org/techniques/keyboard/). This should probably be done in the Form components.
- Margin between the markdown editor and Domain select can be increased a little to match the other inputs:
@tiagoalvesdulce thanks for the feedback!
|
Accessible navigation previewdatepicker-arrow-v2.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keyboard navigation is looking pretty good.
One small thing: after writing the proposal description you should focus on the Save Draft
and Submit
buttons in the bottom when hitting tab
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #2759
Closes #2740
This PR implements the Proposal New page, using the also implemented
RecordForm structure.
Pi
/record/new
)Common-ui
Preview