Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: Add proposal votes search #2863

Merged
merged 7 commits into from
Oct 5, 2022
Merged

multi: Add proposal votes search #2863

merged 7 commits into from
Oct 5, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Sep 29, 2022 •
edited
Loading

Closes #2859

Depends on decred/pi-ui#463

Preview

2859-modal-proposa-votes

@victorgcramos victorgcramos marked this pull request as ready for review September 29, 2022 19:38
tiagoalvesdulce
tiagoalvesdulce approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just fix the conflicts and it should be gtg

tiagoalvesdulce
tiagoalvesdulce approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit bd0fc49 into decred:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[plugin-architecture] Search proposal votes
2 participants
@victorgcramos @tiagoalvesdulce