Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Custom thickness per connection between items #565

Closed
hsch opened this issue Jun 9, 2021 · 3 comments · Fixed by #593
Closed

Custom thickness per connection between items #565

hsch opened this issue Jun 9, 2021 · 3 comments · Fixed by #593
Labels
enhancement New feature or request java Pull requests that update Java code M T-Shirt size for estimation.

Comments

@hsch
Copy link

hsch commented Jun 9, 2021

It could be interesting to support an individual thickness for each connecting line between groups.

I'm using groups to represent micro services, and the thickness could be a way to visualise the amount of traffic between the linked services.

To be clear, this would be a nice-to-have for me. :)

@bonndan bonndan added enhancement New feature or request java Pull requests that update Java code M T-Shirt size for estimation. labels Jun 9, 2021
@bonndan
Copy link
Collaborator

bonndan commented Jun 9, 2021

Could you explain how you get the data on the amount of traffic? What is the source (e.g. grafana, prometheus, ....) and what format does it provide?

Thinking of graphs, we must/should store that information on edges rather than on nodes (what has not been done yet).

@hsch
Copy link
Author

hsch commented Jun 9, 2021

Thinking of graphs, we must/should store that information on edges

Yep, I would agree with this.

Currently I'm using a Splunk query (could potentially turn it into a report and retrieve a CSV or so) with the count of service-to-service requests.

Just note that I'd be okay with managing the data, aggregation, normalisation, and transformation to e.g. [0,1] thickness values (or something like that) myself, and then just add a new value per edge to the landscape YAML. Nothing too fancy needed here.

bonndan pushed a commit that referenced this issue Jun 20, 2021
bonndan pushed a commit that referenced this issue Jun 20, 2021
bonndan pushed a commit that referenced this issue Jun 22, 2021
bonndan pushed a commit that referenced this issue Jun 22, 2021
bonndan pushed a commit that referenced this issue Jun 22, 2021
@bonndan
Copy link
Collaborator

bonndan commented Jun 24, 2021

  • ensure that relations can have labels
  • add and document a new label enum "weight"
  • weight should be used as a factor to modify stroke width (defaults to 1, with reasonable limits, e.g. 0 < factor < 3?)
  • ensure that relation labels can be set via csv and nivio propriertary format
  • ensure that relation descriptions are merged properly
  • show relation labels in FE

bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
bonndan pushed a commit that referenced this issue Jun 24, 2021
@bonndan bonndan changed the title Custom thickness per connection between groups Custom thickness per connection between items Jul 2, 2021
bonndan pushed a commit that referenced this issue Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request java Pull requests that update Java code M T-Shirt size for estimation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants