Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Fix landscape logo in SVG #717

Closed
4 tasks done
bonndan opened this issue Oct 15, 2021 · 0 comments
Closed
4 tasks done

Fix landscape logo in SVG #717

bonndan opened this issue Oct 15, 2021 · 0 comments
Assignees
@jenarp
Labels
biz low business value bug Something isn't working java Pull requests that update Java code M T-Shirt size for estimation.

Comments

@bonndan
Copy link
Collaborator

bonndan commented Oct 15, 2021 •
edited by jenarp
Loading

At the moment the landscape logo cannot be shown in the SVG because it gets lost during processing.

Acceptance criteria

  • icon is visible in SVG (e.g. print view)

Fixes

  • fix that the "icon" is correctly copied from dto to the landscape models and from old to new landscape models (requires new constructor param)
  • fix that AppearanceProcessor correctly sets the _iconData label (resolved icon url) to the landscape
  • fix that SVGDocument reads _iconData instead of using getIcon()
@bonndan bonndan added bug Something isn't working java Pull requests that update Java code labels Oct 15, 2021
@bonndan bonndan added biz low business value M T-Shirt size for estimation. labels Oct 18, 2021
jenarp added a commit that referenced this issue Oct 26, 2021
@jenarp
[#717] fix logo in landscape
179d6ab
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] add setLandscapeAppearance()
cd1a19b
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] add icon + fill to landscape and groups
533d652
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] change constructor of groups
cae2ca3
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] add tests
cf09f9f
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] cleanup
24a94b6
@jenarp jenarp mentioned this issue Oct 29, 2021
Merged
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] some bugs fixed
5d1241e
jenarp added a commit that referenced this issue Oct 29, 2021
@jenarp
[#717] some bugs fixed
9402ade
jenarp added a commit that referenced this issue Nov 3, 2021
@jenarp
[#717] bug fix GroupFactoryTest
23c9bf0
jenarp added a commit that referenced this issue Nov 3, 2021
@jenarp
[#717] bug fix OrganicLayouterTest
36dcac7
jenarp added a commit that referenced this issue Nov 3, 2021
@jenarp
[#717] bug fix JSONAnySetter
6524476
jenarp added a commit that referenced this issue Nov 3, 2021
@jenarp
[#717] create setXXXApperance, remove redundant code
958d58b
jenarp added a commit that referenced this issue Nov 3, 2021
@jenarp
[#717] remove redundant code
7eae0dc
jenarp added a commit that referenced this issue Nov 3, 2021
@jenarp
[#717] cleanup + remove @JSONAnyGettes because not needed
f624158
jenarp added a commit that referenced this issue Nov 5, 2021
@jenarp
[#717] adding @JsonAnySetter/Getter to Group/Item/Landscape + add get…
a0fba55 
…Icon, setICon to ComponentDescription.java and Component.java
jenarp added a commit that referenced this issue Nov 5, 2021
@jenarp
[#717] bug fix unknown property in yaml test
f2d4b1a
jenarp added a commit that referenced this issue Nov 5, 2021
@jenarp
[#717] AppearanceProcessor case item solved
5e3f208
jenarp added a commit that referenced this issue Nov 5, 2021
@jenarp
[#717] AppearanceProcessor case item solved
1d47586
@bonndan bonndan closed this as completed Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jenarp jenarp

Labels
biz low business value bug Something isn't working java Pull requests that update Java code M T-Shirt size for estimation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bonndan @jenarp