Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Prevent/Mitigate false positives in magic label relations #91

Closed
bonndan opened this issue Jan 24, 2020 · 1 comment
Closed

Prevent/Mitigate false positives in magic label relations #91

bonndan opened this issue Jan 24, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bonndan
Copy link
Collaborator

bonndan commented Jan 24, 2020

Provide a means to suppress false relations detected by magic label relations. E.g.: "data" as key used to find relations resulting in relations to a service having a certain label containing "data", which is however used for a completely different purposes and is not suitable to create a relation.

@bonndan bonndan added the bug Something isn't working label Jan 24, 2020
@bonndan bonndan added this to the 0.2.1 milestone Jan 24, 2020
@bonndan
Copy link
Collaborator Author

bonndan commented Jan 27, 2020

Happened when:

  • service was named "data"
  • env var of other service was called FOO_DATA_ASSET and FOO_DATA_HOST (latter pointing at real target)

Possible solutions:

  • configurable blacklist in landscape (arry of strings). here: ['data'] to omit linking
  • check if magic still works even if real target is provided

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant