Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Issue 581 #617

Merged
merged 30 commits into from
Aug 3, 2021
Merged

Issue 581 #617

merged 30 commits into from
Aug 3, 2021

Conversation

robrobert99
Copy link
Collaborator

@robrobert99 robrobert99 commented Jul 19, 2021 •
edited
Loading

image

bonndan
bonndan reviewed Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@bonndan bonndan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising! 🎉

@robrobert99
Move status logic to KPI
1143456 
Add JavaDoc
Move K8sItem factory logic to different class
@robrobert99
Add tests
23c9c75
@robrobert99
Improve tests
f1b7d2b
@robrobert99
Add tests
919d9b2
@robrobert99
Change KubernetesKPI
3718329 
Add KubernetesKPI test
@robrobert99
Change K8sJsonParser
96da79f 
Add tests for K8sJsonParser and K8sConfig
@robrobert99 robrobert99 marked this pull request as ready for review July 27, 2021 13:35
@jpgoelz jpgoelz linked an issue Jul 31, 2021 that may be closed by this pull request
Read k8s cluster contents #581
Closed
5 tasks
Daniel Pozzi and others added 6 commits August 2, 2021 13:09
[#581] extracted k8s label prefix, omitting in api labels
49f25d5
@robrobert99
Improve minikube.md
9e57987
@robrobert99
Merge remote-tracking branch 'origin/issue-581' into issue-581
e6ef49f
@robrobert99
Merge branch 'develop' into issue-581
93d425f 
# Conflicts:
#	docs/source/schema/.openapi-generator/VERSION
#	docs/source/schema/spec.json
#	src/main/app/src/labels.json
#	src/main/java/de/bonndan/nivio/assessment/AssessmentFactory.java
#	src/main/java/de/bonndan/nivio/input/dto/RelationDescription.java
#	src/main/java/de/bonndan/nivio/input/kubernetes/InputFormatHandlerKubernetes.java
#	src/main/java/de/bonndan/nivio/model/Label.java
#	src/test/java/de/bonndan/nivio/model/ItemTest.java
@robrobert99
Merge branch 'develop' into issue-581
c455d77
@robrobert99
Merge develop into feature branch
de6e681
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

95.4% 95.4% Coverage
0.8% 0.8% Duplication

@robrobert99 robrobert99 merged commit 2c2b954 into develop Aug 3, 2021
@jpgoelz jpgoelz deleted the issue-581 branch August 5, 2021 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bonndan bonndan bonndan left review comments

@jpgoelz jpgoelz jpgoelz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read k8s cluster contents
3 participants
@robrobert99 @bonndan @jpgoelz