Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Event observer #646

Merged
merged 24 commits into from
Oct 11, 2021
Merged

Event observer #646

merged 24 commits into from
Oct 11, 2021

Conversation

robrobert99
Copy link
Collaborator

@robrobert99 robrobert99 commented Aug 13, 2021

New feature related to #275.
This feature needs tests and further improvement, before being merged.

robrobert99 and others added 12 commits July 29, 2021 12:09
# Conflicts:
#	docs/source/schema/Models/LandscapeDescription.rst
#	docs/source/schema/spec.json
#	pom.xml
change how observer factory creates observers (file/url based on as f…
# Conflicts:
#	src/main/java/de/bonndan/nivio/input/kubernetes/InputFormatHandlerKubernetes.java
# Conflicts:
#	src/main/java/de/bonndan/nivio/input/Seed.java
@robrobert99 robrobert99 added enhancement New feature or request java Pull requests that update Java code S T-Shirt size for estimation. labels Aug 13, 2021
@robrobert99 robrobert99 marked this pull request as ready for review August 18, 2021 12:58
@robrobert99 robrobert99 reopened this Aug 18, 2021
@robrobert99 robrobert99 marked this pull request as draft August 18, 2021 13:00
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@robrobert99 robrobert99 added biz medium business value M T-Shirt size for estimation. and removed S T-Shirt size for estimation. labels Oct 5, 2021
@robrobert99 robrobert99 requested review from bonndan and jenarp October 6, 2021 10:29
@robrobert99 robrobert99 marked this pull request as ready for review October 6, 2021 10:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.9% 84.9% Coverage
0.0% 0.0% Duplication

@robrobert99 robrobert99 requested a review from bonndan October 11, 2021 13:46
Copy link
Collaborator

@bonndan bonndan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's start using this approach.

@robrobert99 robrobert99 merged commit 3233f64 into develop Oct 11, 2021
@robrobert99 robrobert99 deleted the event_observer branch November 16, 2021 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
biz medium business value enhancement New feature or request java Pull requests that update Java code M T-Shirt size for estimation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants