This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
141 user database advanced #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml
741 oauth2
… 141_user_database_advanced # Conflicts: # src/test/java/de/bonndan/nivio/appuser/AppUserRepositoryTest.java
… 141_user_database_advanced
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
src/test/java/de/bonndan/nivio/appuser/AppUserRepositoryTest.java
Outdated
Show resolved
Hide resolved
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
bonndan
reviewed
Jan 24, 2022
src/test/java/de/bonndan/nivio/security/CustomOAuth2UserServiceTest.java
Outdated
Show resolved
Hide resolved
bonndan
reviewed
Jan 24, 2022
src/test/java/de/bonndan/nivio/security/CustomOAuth2UserServiceTest.java
Outdated
Show resolved
Hide resolved
bonndan
reviewed
Jan 24, 2022
bonndan
suggested changes
Jan 24, 2022
jenarp
commented
Jan 28, 2022
src/test/java/de/bonndan/nivio/security/CustomOAuth2UserServiceTest.java
Outdated
Show resolved
Hide resolved
robrobert99
reviewed
Feb 1, 2022
| if (StringUtils.hasLength(nameAttribute)) { | ||
| id = String.valueOf(user.getAttribute("id") == null ? "" : user.getAttribute("id")); | ||
| externalId = String.valueOf(user.getAttribute("id") == null ? "" : user.getAttribute("id")); |
There was a problem hiding this comment.
Maybe use if/else instead of the ternary operator to increase the readability.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles ticket #141.