Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the information displayed in the service metadata example of deegree #1712

Merged

Conversation

julianzz98
Copy link
Contributor

The information was changed so it matches the information of already adjusted example templates.

This PR closes issue #1551.

@julianzz98 julianzz98 added enhancement enhancement or improvement ready easy labels Jun 7, 2024
@tfr42
Copy link
Member

tfr42 commented Jun 7, 2024

For fictitious purposes we should use numbers like this for the US: +1 206 555 0100 - +1 206 555 0199 or similar in the UK +44 113 496 0000 - +44 113 496 0999
For Germany there are some defined in https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/Mittlg148_2021.pdf?__blob=publicationFile&v=1

@julianzz98
Copy link
Contributor Author

julianzz98 commented Jun 13, 2024

The phone number was changed to 0000/000000 and the email to [email protected]. This was done despite your suggestion, since all the other example templates (e.g. for the capabilties) are formatted this way.

The usage of the example email address should be fine (see https://www.iana.org/help/example-domains).

@copierrj copierrj merged commit 9cf946b into deegree:main Jul 3, 2024
1 check passed
@tfr42 tfr42 added this to the 3.6 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement enhancement or improvement ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants