Try Test Suite

deepgarg-visa · Apr 3, 2024 · 3ad584e · 3ad584e
1 parent 104048b
commit 3ad584e
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 10 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -68,11 +68,6 @@ jobs:
           distribution: "zulu"
           java-version: 17
       - uses: gradle/gradle-build-action@v2
-      - uses: actions/setup-python@v4
-        if: ${{ needs.setup.outputs.ingestion_change == 'true' }}
-        with:
-          python-version: "3.10"
-          cache: pip
       - name: Gradle build (and test) for NOT metadata ingestion
         if: ${{  matrix.command == 'except_metadata_ingestion' && needs.setup.outputs.backend_change == 'true' }}
         run: |
@@ -118,9 +113,6 @@ jobs:
     steps:
       - name: Check out the repo
         uses: acryldata/sane-checkout-action@v3
-      - uses: actions/setup-python@v4
-        with:
-          python-version: "3.10"
       - name: Quickstart Compose Validation
         run: ./docker/quickstart/generate_and_compare.sh
 

diff --git a/datahub-web-react/src/Mocks.tsx b/datahub-web-react/src/Mocks.tsx
@@ -1857,6 +1857,42 @@ export const mlModelGroup = {
 } as MlModelGroup;
 
 export const recommendationModules = [
+    {
+        title: 'Datasets',
+        moduleId: 'Datasets',
+        renderType: RecommendationRenderType.EntityNameList,
+        content: [
+            {
+                entity: {
+                    ...dataset2,
+                },
+            },
+        ],
+    },
+    {
+        title: 'Explore your data',
+        moduleId: 'Exploreyourdata',
+        renderType: RecommendationRenderType.EntityNameList,
+        content: [
+            {
+                entity: {
+                    ...dataset2,
+                },
+            },
+        ],
+    },
+    {
+        title: 'Some Other Dataset 1',
+        moduleId: 'SomeOtherDataset1',
+        renderType: RecommendationRenderType.EntityNameList,
+        content: [
+            {
+                entity: {
+                    ...dataset2,
+                },
+            },
+        ],
+    },
     {
         title: 'Most Popular',
         moduleId: 'MostPopular',

diff --git a/datahub-web-react/src/app/recommendations/__tests__/Recommendations.test.tsx b/datahub-web-react/src/app/recommendations/__tests__/Recommendations.test.tsx
@@ -31,7 +31,7 @@ describe('Recommendations', () => {
         await waitFor(() => expect(getByText('Popular Tags')).toBeInTheDocument());
         await waitFor(() => expect(getByText('TestTag')).toBeInTheDocument());
         await waitFor(() => expect(getByText('Most Popular')).toBeInTheDocument());
-        await waitFor(() => expect(getByText('Some Other Dataset')).toBeInTheDocument());
+        await waitFor(() => expect(getByText('Some Other Dataset 1')).toBeInTheDocument());
     });
 
     it('search results renders recommendations', async () => {
@@ -55,7 +55,7 @@ describe('Recommendations', () => {
         await waitFor(() => expect(getByText('Popular Tags')).toBeInTheDocument());
         await waitFor(() => expect(getByText('TestTag')).toBeInTheDocument());
         await waitFor(() => expect(getByText('Most Popular')).toBeInTheDocument());
-        await waitFor(() => expect(getByText('Some Other Dataset')).toBeInTheDocument());
+        await waitFor(() => expect(getByText('Some Other Dataset 1')).toBeInTheDocument());
     });
 
     // TODO: Uncomment once entity sidebar recs are fully supported.

diff --git a/smoke-test/tests/cypress/cypress/e2e/mutations/mutations.js b/smoke-test/tests/cypress/cypress/e2e/mutations/mutations.js
@@ -179,6 +179,7 @@ describe("mutations", () => {
 
     cy.goToDataset("urn:li:dataset:(urn:li:dataPlatform:hive,cypress_logging_events,PROD)", "cypress_logging_events");
     cy.clickOptionWithText("event_data");
+    cy.wait(2000);
     cy.get('[data-testid="schema-field-event_data-businessAttribute"]').trigger(
         "mouseover",
         { force: true }