Adds Missing ExpirationDate Field on Key Object #320
Conversation
WalkthroughThe recent update introduces a new Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Deepgram/Models/Manage/v1/Key.cs (1 hunks)
Additional comments not posted (1)
Deepgram/Models/Manage/v1/Key.cs (1)
51-56: LGTM! Verify JSON serialization attributes.The
ExpirationDateproperty is well-documented and follows the existing pattern. Ensure that theJsonIgnoreandJsonPropertyNameattributes are correctly applied.Verification successful
Verified! The JSON serialization attributes for the
ExpirationDateproperty are correctly applied.The
ExpirationDateproperty inDeepgram/Models/Manage/v1/Key.cshas the appropriateJsonIgnoreandJsonPropertyNameattributes, ensuring correct JSON serialization behavior.
JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)JsonPropertyName("expiration_date")Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the JSON serialization attributes of the ExpirationDate property. # Test: Search for the ExpirationDate property and check its attributes. rg --type cs -A 5 $'public DateTime? ExpirationDate { get; set; }'Length of output: 229
Script:
#!/bin/bash # Description: Verify the JSON serialization attributes of the ExpirationDate property. # Test: Search for the ExpirationDate property and check its attributes. rg --type cs -A 5 $'public DateTime\\? ExpirationDate { get; set; }'Length of output: 232
Script:
#!/bin/bash # Description: Verify the JSON serialization attributes of the ExpirationDate property. # Test: Search for the ExpirationDate property and check its attributes. rg --type cs -A 5 'public DateTime? ExpirationDate { get; set; }'Length of output: 229
Script:
#!/bin/bash # Description: Verify the JSON serialization attributes of the ExpirationDate property. # Test: Search for the ExpirationDate property and check its attributes. grep -F -A 5 'public DateTime? ExpirationDate { get; set; }' $(find . -name '*.cs')Length of output: 14532
Proposed changes
Addresses issue: #319
Types of changes
What types of changes does your code introduce to the community .NET SDK?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA
Summary by CodeRabbit
New Features
ExpirationDateproperty for API keys, allowing better management of key lifecycle.Documentation
ExpirationDateproperty.