Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Serialize for all response types #28

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

andrewhalle
Copy link
Contributor

Why?
Fixes #27.

Copy link

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 ✨

@yottalogical
Copy link
Contributor

A possible reason not to put Eq on everything that can support it is so that non-Eq fields (such as floating point numeral) can be added in the future without causing a breaking change.

Same reason why Rust for Rustaceans recommends against libraries putting Copy on everything that can support it.

@andrewhalle
Copy link
Contributor Author

andrewhalle commented Sep 2, 2022

Ah yeah, fair enough. I'll put an #![allow] for this lint for now and leave it to be decided later.

@andrewhalle
Copy link
Contributor Author

Squashing and rebasing before merging.

@andrewhalle andrewhalle force-pushed the andrewhalle-derive-serialize branch from 19eeb6e to 9bc3a1a Compare September 2, 2022 19:26
@andrewhalle andrewhalle merged commit 858405a into dev Sep 2, 2022
@andrewhalle andrewhalle deleted the andrewhalle-derive-serialize branch September 2, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants