Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary query params. #69

Closed
wants to merge 13 commits into from
Closed

Conversation

jcdyer
Copy link
Contributor

@jcdyer jcdyer commented Jul 3, 2024

Proposed changes

Add the ability to include arbitrary query parameters. Since this crate is not officially supported, it may occasionally fall behind on supporting the latest API options. Including a .query_params method on the builder provides an escape hatch, so SDK users can make use of new features.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc
  • I have added tests and/or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Sorry, something went wrong.

jcdyer added 10 commits July 3, 2024 09:59
…ests.

Since Deepgram doesn't officially support the rust SDK, it may
occasionally fall behind in feature support.  This change will make it
possible for rust developers to make use of arbitrary new features through
the SDK before a new version gets released.
fmt
@jcdyer jcdyer requested a review from andrewhalle July 3, 2024 16:06
jcdyer added 3 commits July 3, 2024 13:50
@jcdyer jcdyer changed the base branch from main to featurize-transcription-modes July 3, 2024 18:08
Base automatically changed from featurize-transcription-modes to expand-languages July 3, 2024 20:16
@jcdyer jcdyer deleted the branch expand-languages July 3, 2024 20:17
@jcdyer jcdyer closed this Jul 3, 2024
@jcdyer
Copy link
Contributor Author

jcdyer commented Jul 3, 2024

Gah. I messed up the merging. I'll need to open a new PR for this.

@jcdyer jcdyer mentioned this pull request Jul 5, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants