Test to make sure JPY PyObject.getXXXValue() errors out immediately #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
NoDocumentationNeeded
jpy
NoReleaseNotesNeeded
jmao-denver
changed the title
chipkent
previously approved these changes
Apr 3, 2023
jmao-denver
force-pushed
the
3597-jpy-exception-test
branch
from
654eea0 to
ecec75f
Compare
devinrsmith
reviewed
Apr 19, 2023
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/ErrorOutTest.java
Show resolved
Hide resolved
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/ErrorOutTest.java
Show resolved
Hide resolved
|
Given the lossy nature of getIntValue(), we should audit all of our own uses of it and switch over to more precise calls: Math.toIntExact(valueIn.getLongValue())or something equivalent to that (considering int, short, byte, and char consumer). |
|
Follow-up #3716 |
devinrsmith
approved these changes
Apr 20, 2023
rcaudy
approved these changes
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3597
Linked to: jpy-consortium/jpy#99