Add endpointOverride S3 support #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
DocumentationNeeded
ReleaseNotesNeeded
devinrsmith
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
extensions/s3/src/test/java/io/deephaven/extensions/s3/S3SeekableChannelTestBase.java
Outdated
Show resolved
Hide resolved
malhotrashivam
previously approved these changes
Jan 31, 2024
rcaudy
reviewed
Feb 1, 2024
extensions/s3/src/main/java/io/deephaven/extensions/s3/AwsCredentials.java
Outdated
Show resolved
Hide resolved
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3Instructions.java
Show resolved
Hide resolved
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3Instructions.java
Outdated
Show resolved
Hide resolved
extensions/s3/src/test/java/io/deephaven/extensions/s3/SingletonContainers.java
Outdated
Show resolved
Hide resolved
extensions/s3/src/test/java/io/deephaven/extensions/s3/SingletonContainers.java
Show resolved
Hide resolved
extensions/s3/src/test/java/io/deephaven/extensions/s3/S3SeekableChannelTestBase.java
Outdated
Show resolved
Hide resolved
extensions/s3/src/test/java/io/deephaven/extensions/s3/S3SeekableChannelMinIOTest.java
Show resolved
Hide resolved
rcaudy
reviewed
Feb 2, 2024
extensions/s3/src/main/java/io/deephaven/extensions/s3/BasicCredentials.java
Show resolved
Hide resolved
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3Instructions.java
Outdated
Show resolved
Hide resolved
chipkent
reviewed
Feb 5, 2024
| used from software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider. | ||
| access_key_id (str): the access key for reading parquet files stored in S3. Both access key and secret | ||
| access key must be provided to use static credentials, else default credentials will be used. | ||
| secret_access_key (str): the secret access key for reading parquet files stored in S3. Both access key and |
There was a problem hiding this comment.
This says "S3", while newer edits in other places carefully use "S3-compatible". Is this just S3, or should the docs be rephrased as compatible?
There was a problem hiding this comment.
Thanks. I think saying "S3" is a bit redundant given the module and class name. Also, I don't think we need / want to be explicitly calling out parquet files here, so I've gone ahead and done a light edit of some of the other pydocs.
…tegration-testing
chipkent
previously approved these changes
Feb 6, 2024
rcaudy
previously approved these changes
Feb 6, 2024
rcaudy
approved these changes
Feb 7, 2024
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: https://github.com/deephaven/deephaven.io/issues/3686 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to set an endpoint override for S3Instructions. This allows Deephaven to connect to S3-compatible APIs (not just AWS S3) such as backblaze or minio.
In addition, this adds java S3 local integration testing using testcontainers-java, via a localstack container and a minio container.
In support of #5064.