Use IrisGridUtils to display partition selector value

deephaven · Sep 25, 2023 · a10df88 · a10df88
1 parent 8b35647
commit a10df88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/iris-grid/src/IrisGrid.tsx b/packages/iris-grid/src/IrisGrid.tsx
@@ -1939,10 +1939,7 @@ export class IrisGrid extends Component<IrisGridProps, IrisGridState> {
           partitionColumn.name
         )
       );
-    } else if (
-      partitionColumn.type === 'java.lang.Boolean' ||
-      partitionColumn.type === 'boolean'
-    ) {
+    } else if (partitionColumn.type === 'java.lang.Boolean') {
       partitionFilterValue = model.dh.FilterValue.ofBoolean(partition);
     } else {
       partitionFilterValue = model.dh.FilterValue.ofNumber(partition);

diff --git a/packages/iris-grid/src/IrisGridPartitionSelector.tsx b/packages/iris-grid/src/IrisGridPartitionSelector.tsx
@@ -7,6 +7,7 @@ import debounce from 'lodash.debounce';
 import type { Column, dh as DhType, Table } from '@deephaven/jsapi-types';
 import PartitionSelectorSearch from './PartitionSelectorSearch';
 import './IrisGridPartitionSelector.scss';
+import IrisGridUtils from './IrisGridUtils';
 
 const log = Log.module('IrisGridPartitionSelector');
 
@@ -184,9 +185,10 @@ class IrisGridPartitionSelector<T> extends Component<
           <input
             type="text"
             value={
+              // IrisGridUtils.convertValueToText(partition, column.type)
               column.type === 'char' && partition.toString().length > 0
                 ? String.fromCharCode(parseInt(partition, 10))
-                : partition
+                : IrisGridUtils.convertValueToText(partition, column.type)
             }
             onChange={this.handlePartitionChange}
             className="form-control input-partition"