Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering edit mode on a cell in an input table should not clear the cell contents #1087

Closed
dsmmcken opened this issue Feb 14, 2023 · 1 comment · Fixed by #1090
Closed

Entering edit mode on a cell in an input table should not clear the cell contents #1087

dsmmcken opened this issue Feb 14, 2023 · 1 comment · Fixed by #1090
Assignees
Labels
bug Something isn't working

Comments

@dsmmcken
Copy link
Contributor

Description

Create an input table, example:

from deephaven import input_table
from deephaven import dtypes as dht

my_col_defs = {
    "Integers": dht.int32,
    "Doubles": dht.double,
    "Strings": dht.string
}

result = input_table(col_defs=my_col_defs, key_cols="Integers")

Steps to reproduce

  1. double click a cell (or use F2) to enter edit mode
  2. enter a value
  3. select another cell
  4. double click the original cell

Expected results

The cell should have the contents still., and the cursor should be at the end of the cell.

Actual results

Contents of the cell are getting cleared.

Additional details and attachments

Regression maybe happened during typescript conversion?

Versions

Engine Version: 0.21.0
Web UI Version: 0.28.0
Java Version: 17.0.6
Barrage Version: 0.5.0

@dsmmcken dsmmcken added bug Something isn't working triage Issue requires triage labels Feb 14, 2023
@dsmmcken
Copy link
Contributor Author

Note: this should be treated as a blocker for silverheels as it significantly degrades users ability to edit input tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants