Support reconnecting to the server #1140
Labels
enhancement
New feature or request
Milestone
Comments
Merged
mofojed
added a commit
that referenced
this issue
Mar 29, 2023
- Listen for `EVENT_DISCONNECT` and `EVENT_RECONNECT` on the connection, and display a "Reconnecting..." message in the console. - No longer listen to the `HACK_CONNECTION_FAILURE` (it's been deprecated). - Listen for the `SHUTDOWN` event and display a message after shutdown. - Fixes #1140 Testing steps: 1. Start up server with deephaven-core JS API reconnect changes: deephaven/deephaven-core#3502 2. Use ngrok to start a tunnel to that port, e.g.: `ngrok http 10000` 3. Start up Web UI connecting to that tunnel, e.g.: `VITE_CORE_API_URL=http://acfc-23-233-0-34.ngrok.io/jsapi npm start` 4. Open the Web UI in Firefox, run some commands to make sure initial connection is fine. 5. Press Alt and from the File menu, select "Work Offline" 6. See it transition to a disconnected state. Disconnected message should appear and should not be able to enter new commands 7. Reconnect by deselecting "Work Offline" option from Step 5 8. See it transition to connected state. Should be able to run commands and have the results appear. 9. Kill the server (Ctrl+C). See it transition to a Shutdown state, app unloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a user, if I momentarily lose connection to a running server (wifi/vpn drops, laptop lid closes), I would like to continue using the console/app without refreshing the page.
With deephaven/deephaven-core#3502 merged, the
dh.IdeConnection.HACK_CONNECTION_FAILUREis deprecated, and no longer needed, but still left in place until the web UI is updated to support disconnect/reconnect events.Tables and figures are functional already, but the console component for the
dh.IdeConnectiondoes not hint to the user that the connection is lost and commands cannot be run, until the reconnect event occurs.Note that in some cases the session might have expired or the server restarted and all sessions invalidated. In this case, the disconnect event will still occur, but the JS API cannot yet create a new session (see deephaven/deephaven-core#3501), so instead the
dh.CoreClient.EVENT_RECONNECT_AUTH_FAILEDevent will be fired from thedh.CoreClientinstance.The text was updated successfully, but these errors were encountered: