Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker with one click plots doesn't filter plot #1198

Closed
dsmmcken opened this issue Apr 3, 2023 · 0 comments · Fixed by #1217
Closed

Linker with one click plots doesn't filter plot #1198

dsmmcken opened this issue Apr 3, 2023 · 0 comments · Fixed by #1217
Assignees
Labels
blocker bug Something isn't working
Milestone

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Apr 3, 2023

Description

Attempting to filter a one_click plot with value supplied via linker doesn't filter the selectable_dataset. Issue present in DHC and DHE, will require hotfix.

Reported by @rbasralian in Silverheels 1.20230131.113 on Slack.

Steps to reproduce

  1. Use the following query:
    from deephaven import empty_table, time_table
    from deephaven.plot.figure import Figure
    from deephaven.plot.selectable_dataset import one_click
    
    simple_ticking = time_table("00:00:01").update([
            "MyString=new String(`a`+(char) ((i%3)+97))",
            "MyInt=new Integer(i)",
            "MyLong=new Long(i % 3)",
            "MyDouble=new Double(i+i/10)",
            "MyFloat=new Float(i+i/10)",
            "MyBoolean=new Boolean(i%2==0)",
            "MyChar= new Character((char) ((i%26)+97))",
            "MyShort=new Short(Integer.toString(i%32767))",
            "MyByte= new java.lang.Byte(Integer.toString(i%127))"])
    
    
    toc = one_click(simple_ticking, by=["MyString"], require_all_filters=True)
    p = Figure().plot_xy(series_name="Distance", t=toc, x="Timestamp", y="MyInt").show()
    
    
  2. Create a linker between the plot and the "MyString" column in the table.
  3. Double click a row in the table simple_ticking to filter the plot by that value

image

Expected results

Plot is updated to show a result.

Actual results

Nothing happens.

Additional details and attachments

Adding an input filter panel set to the "MyString" column and entering a value like aa does work.

Versions

Silverheels: 1.20230131.113

and DHC:
Engine Version: 0.24.0
Web UI Version: 0.34.0
Java Version: 17.0.6
Barrage Version: 0.5.0

@dsmmcken dsmmcken added bug Something isn't working triage Issue requires triage labels Apr 3, 2023
@vbabich vbabich added this to the April 2023 milestone Apr 5, 2023
@vbabich vbabich added blocker and removed triage Issue requires triage labels Apr 5, 2023
@vbabich vbabich self-assigned this Apr 5, 2023
vbabich added a commit that referenced this issue Apr 17, 2023
- Update `ChartPanel` to get the filter value from `filterList`
- Hide operator selection for filter source and chart links
- Don't allow linking multiple columns from the same table to a chart
target
- Fix issue with link in progress not being reset after creating a new
link

Fixes #1198
vbabich added a commit to vbabich/web-client-ui that referenced this issue Apr 17, 2023
- Update `ChartPanel` to get the filter value from `filterList`
- Hide operator selection for filter source and chart links
- Don't allow linking multiple columns from the same table to a chart
target
- Fix issue with link in progress not being reset after creating a new
link

Fixes deephaven#1198
vbabich added a commit that referenced this issue Apr 17, 2023
Cherry-pick #1217

- Update `ChartPanel` to get the filter value from `filterList`
- Hide operator selection for filter source and chart links
- Don't allow linking multiple columns from the same table to a chart
target
- Fix issue with link in progress not being reset after creating a new
link

Fixes #1198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants