-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Clean up golden-layout css #1322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto the package, will make it easier to theme later.
Codecov Report
@@ Coverage Diff @@
## main #1322 +/- ##
==========================================
- Coverage 45.95% 45.94% -0.01%
==========================================
Files 493 493
Lines 34404 34410 +6
Branches 8580 8581 +1
==========================================
Hits 15811 15811
- Misses 18542 18548 +6
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
requested changes
May 29, 2023
Co-authored-by: Mike Bender <[email protected]>
mofojed
approved these changes
May 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain our golden-layout package, bake our theme customizations directly into the dark theme. Eliminates some css. Used e2e testing to prevent visual regressions, the two changes showing are intentional.
Had to exclude the ThemeExport from the karma tests, it didn't like the scss import.