Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean up golden-layout css #1322

Merged
merged 12 commits into from
May 29, 2023
Merged

refactor: Clean up golden-layout css #1322

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0cbb2ec
refactor: Moves most of our customization of golden-layout directly i…
dsmmcken May 24, 2023
baf900b
improve wording of comment
dsmmcken May 25, 2023
de93ebc
update tests and adjust last things
dsmmcken May 25, 2023
87313e6
adjust drag proxy right border
dsmmcken May 25, 2023
ad566e3
import for custom css vars
dsmmcken May 25, 2023
f260771
fix lock
dsmmcken May 25, 2023
028200d
add load path?
dsmmcken May 25, 2023
f821296
try excluding the scss import karma doesn't understand
dsmmcken May 25, 2023
665a7eb
stabbing in the dark
dsmmcken May 25, 2023
1116272
maybe maybe maybe
dsmmcken May 25, 2023
39d1dcf
should be @use not @import
dsmmcken May 25, 2023
7bc888a
Update packages/dashboard/src/PanelPlaceholder.scss
dsmmcken May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion packages/dashboard/src/PanelPlaceholder.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
display: flex;
flex-direction: column;
justify-content: center;
padding: $spacer-3;
min-height: 100%;
max-height: 100%;
text-align: center;
overflow: hidden;

// add padding on a iner wrapper so it is included in max height of parent
dsmmcken marked this conversation as resolved.
Show resolved Hide resolved
div {
padding: $spacer-3;
}
}
2 changes: 1 addition & 1 deletion packages/dashboard/src/PanelPlaceholder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const PanelPlaceholder = React.forwardRef(
const component = LayoutUtils.getComponentNameFromPanel({ props });
return (
<div ref={ref} className="panel-placeholder">
Component &quot;{component}&quot; is not registered.
<div>Component &quot;{component}&quot; is not registered.</div>
</div>
);
}
Expand Down
9 changes: 0 additions & 9 deletions packages/dashboard/src/layout/GoldenLayout.module.scss
View file
Open in desktop

This file was deleted.

Loading