Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionUtils has a self package import from @deephaven/jsapi-utils #1497

Closed
bmingles opened this issue Sep 8, 2023 · 0 comments · Fixed by #1499
Closed

SessionUtils has a self package import from @deephaven/jsapi-utils #1497

bmingles opened this issue Sep 8, 2023 · 0 comments · Fixed by #1499
Assignees
@bmingles
Labels
bug Something isn't working triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

bmingles commented Sep 8, 2023

Description

SessionUtils has an import from its owning package @deephaven/jsapi-utils. We should fix this and configure eslint to disallow such imports.
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Sep 8, 2023
@bmingles bmingles self-assigned this Sep 8, 2023
@bmingles bmingles mentioned this issue Sep 8, 2023
Closed
bmingles added a commit to bmingles/web-client-ui that referenced this issue Sep 8, 2023
@bmingles
Fixed comment
91182bb 
deephaven#1497
bmingles added a commit to bmingles/web-client-ui that referenced this issue Sep 8, 2023
@bmingles
Forbid @deephaven modules from self importing
1f584e5 
deephaven#1497
@bmingles bmingles mentioned this issue Sep 8, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Sep 8, 2023
@bmingles
Block comment
e358402 
deephaven#1497
bmingles added a commit that referenced this issue Sep 8, 2023
@bmingles
fix: Forbid @deephaven modules from self importing (#1499)
81cdd65 
- Eslint rules to forbid importing from @deephaven package owning the
module
- Fixed offending SessionUtils

I tested this by running npm run test:lint. It showed expected linting
error before fixing SessionUtils. Fixing SessionUtils made error go
away. Also tested in vscode. Error shows up in the editor as expected.

fixes #1497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
1 participant
@bmingles