fix: Render tables partitioned by non-string columns

[georgecwan]

• Partitioned tables were unable to be rendered if the partitioned column type is not java.lang.String
• Grid can now render string, numerical, and character columns
• Fixes partitioning columns filter dropdown to correctly display char types instead of their ASCII values
• The partition search bar function is now able to search for numbers
• Removes the handleFocus function for PartitionSelectorSearch since it made it impossible for the user to edit the search bar after deselecting it
• Fixes Partition-selection drop-downs don't work properly for non-String columns #1441

[codecov]

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (d796f83) 46.42% compared to head (aff1bf2) 46.41%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1533      +/-   ##
==========================================
- Coverage   46.42%   46.41%   -0.02%     
==========================================
  Files         558      564       +6     
  Lines       35714    35765      +51     
  Branches     8916     8946      +30     
==========================================
+ Hits        16582    16599      +17     
- Misses      19082    19116      +34     
  Partials       50       50              

Flag	Coverage Δ
unit	46.41% <45.45%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/iris-grid/src/PartitionSelectorSearch.tsx	69.75% <81.25%> (-4.11%)	⬇️
...ckages/iris-grid/src/IrisGridPartitionSelector.tsx	34.48% <22.22%> (-0.97%)	⬇️
packages/iris-grid/src/IrisGrid.tsx	26.84% <0.00%> (-0.13%)	⬇️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[georgecwan]

There is still an error that occurs when trying to partition by a boolean column:

heduler-Concurrent-2 | i.d.s.s.SessionService    | Internal Error '5c0a20aa-a105-4ad6-b89f-f1aab9995272' java.lang.IllegalArgumentException: Unknown type boolean for MatchFilter value auto-conversion

The code I ran is:

from deephaven import empty_table

part = empty_table(4).update("II=ii")

from deephaven.parquet import write, read

write(part, "/tmp/bool-test/boolCol=true/part.parquet")
write(part, "/tmp/bool-test/boolCol=false/part.parquet")

partition_table = read("/tmp/bool-test")

I suspect that the type of the boolCol being boolean instead of java.lang.Boolean might be related to the issue. I am not sure how to resolve this, some help would be appreciated.

[mofojed]

@georgecwan For the different column type (boolean vs java.lang.Boolean), I'd check in #ddl-team-dhc if that is expected or not. It seems like boolean is always promoted to a java.lang.Boolean when you create a new table, but not in this case. E.g. if you do:

from deephaven import empty_table
t = empty_table(100).update("x=(boolean)(i%2==0)")
print(t.columns)

You get:

[Column(name='x', data_type=java.lang.Boolean, component_type=None, column_type=NORMAL)]

[georgecwan]

Error with types boolean vs java.lang.Boolean will be resolved in deephaven/deephaven-core#4547. I have tested my changes against that PR and tables partitioned on boolean columns will work on that version of dh-core.