Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WidgetPlugin type should be generic #1759

Closed
bmingles opened this issue Jan 30, 2024 · 2 comments · Fixed by #1760 or #1769
Closed

WidgetPlugin type should be generic #1759

bmingles opened this issue Jan 30, 2024 · 2 comments · Fixed by #1760 or #1769
Assignees
@bmingles
Labels
bug Something isn't working

Comments

@bmingles
Copy link
Contributor

Upgrading the plugins repo to the latest DHC release 0.60.0 introduces type errors in some panels when instantiating PlotlyExpressChartModel. This can be fixed by making the WidgetPlugin type generic for the type of widget it applies to.
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Jan 30, 2024
@bmingles bmingles self-assigned this Jan 30, 2024
@mattrunyon
Copy link
Collaborator

What type errors are you getting and what are you proposing should be generic? The only thing I could maybe see is WidgetComponentProps.fetch returning something you can specify instead of casting it when you fetch

@bmingles
Copy link
Contributor Author

What type errors are you getting and what are you proposing should be generic? The only thing I could maybe see is WidgetComponentProps.fetch returning something you can specify instead of casting it when you fetch

image

@mofojed and I actually discussed this last week. See the attached PR for what we came up with.

@bmingles bmingles mentioned this issue Jan 30, 2024
Merged
bmingles added a commit that referenced this issue Jan 30, 2024
@bmingles
fix: Made WidgetComponentProps generic (#1760)
8cb0a10 
Made `PluginType` generic. This fixes a breaking change that impacts
`PlotlyExpressChartPanel` and `PlotlyExpressChart` in the plugins repo
so that our next version bump will be cleaner.

fixes #1759
@mattrunyon mattrunyon removed the triage Issue requires triage label Jan 30, 2024
@bmingles bmingles reopened this Feb 1, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 1, 2024
@bmingles
Made some plugin types generic
e0474e6 
deephaven#1759
@bmingles bmingles mentioned this issue Feb 1, 2024
Merged
bmingles added a commit that referenced this issue Feb 2, 2024
@bmingles
fix: Made some plugin types generic (#1769)
ac40c6f 
I missed making `WidgetPanelProps` generic in the last PR which is
needed to version bump plotly express.
resolves #1759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@bmingles @mattrunyon