Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH-16914: optimizeSelection needs getKey function #1993

Closed
bmingles opened this issue May 7, 2024 · 0 comments · Fixed by #1994
Closed

DH-16914: optimizeSelection needs getKey function #1993

bmingles opened this issue May 7, 2024 · 0 comments · Fixed by #1994
Assignees
@bmingles

Comments

@bmingles
Copy link
Contributor

bmingles commented May 7, 2024

Viewport data no longer uses stringified numbers as the top level item keys but uses createKeyedItemKey to add a prefix to the numbers. This breaks SelectionUtils.optimizeSelection which still generates keys by simple numeric strings. This is the root cause of DH-16914. We should be able to fix this by adding an additional getKey argument to allow the caller to customize the key generation.
@bmingles bmingles self-assigned this May 7, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 7, 2024
@bmingles
Added getKey to SelectionUtils.optimizeSelection (deephaven#1993)
decb578
@bmingles bmingles linked a pull request May 7, 2024 that will close this issue
fix: Added getKey to SelectionUtils.optimizeSelection #1994
Merged
@mofojed mofojed closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Added getKey to SelectionUtils.optimizeSelection bmingles/web-client-ui
2 participants
@bmingles @mofojed