Middle-click to close panel sometimes pastes text in another location

[mofojed]

Description

If you middle click to close a panel, it sometimes pastes in another panel. I think this is because the close is triggered on down instead of up.

Steps to reproduce

1. Arrange tables like in the video. Can execute this query to get a table/plot:

from deephaven.plot.figure import Figure
from deephaven import read_csv

insurance = read_csv("https://media.githubusercontent.com/media/deephaven/examples/main/Insurance/csv/insurance.csv")
insurance_by_region = insurance.view(formulas=["region", "expenses"]).sum_by(["region"])

figure = Figure()
new_fig = figure.plot_pie(series_name="Insurance charges by region", t=insurance_by_region, category="region", y="expenses")
new_plot = new_fig.show()

2. Close the plot panel with a middle click in the panel tab.

Expected results
2. Panel is closed, no text is pasted

Actual results
2. Panel is closed, but text from my clipboard is pasted into the console input

Additional details and attachments

middle-click.mp4

Versions

• Deephaven: Version 0.11.7
• OS: Ubuntu
• Browser: Chrome

[vbabich]

Should it be triggered on click and not mouse up/down?

[dsmmcken]

Noting: middle click paste is a linux only thing, maybe just needs a prevent default or something.

[dsmmcken]

Assigned to @mofojed, none of us run linux so we won't easily be able to test if our fixes work. See golden-layout Tabs.js _onTabClick button === 1 should probably preventDefault.