fix: Goto Value Skips Rows on String Column, Displays Incorrect Filter, and shift+enter Doesn't go to Previous
#1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 44.13% 44.15% +0.01%
==========================================
Files 447 447
Lines 33265 33266 +1
Branches 8356 8355 -1
==========================================
+ Hits 14682 14687 +5
+ Misses 18534 18530 -4
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
requested changes
Mar 20, 2023
mofojed
requested changes
Mar 20, 2023
mofojed
requested changes
Mar 20, 2023
mofojed
requested changes
Mar 20, 2023
Zhou-Ziheng
changed the title
shift+enter Doesn't go to Previous
|
Looks like shift+Enter to go to previous was never implemented, so I added that as well in this PR. |
mofojed
approved these changes
Mar 20, 2023
| @@ -100,11 +102,11 @@ function GotoRow({ | |||
| } | |||
| }; | |||
|
|
|||
| const handleGotoValueKeyDown = (e: KeyboardEvent<HTMLInputElement>) => { | |||
| const handleGotoValueKeySubmit = (e: KeyboardEvent<HTMLInputElement>) => { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1156, #1157