[lmi][vllm][trtllm] add support for generation parameters fron genera… #2685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion_config.json
Description
This will resolve #2672.
Note, this feature is available in vllm as of 0.6.6, but we currently use 0.6.3.post1. See this commit from vllm vllm-project/vllm@5aef498.
Once we upgrade to 0.6.6, we should be able to rely on vllm for this directly.
To enable this behavior, users must set
OPTION_GENERATION_CONFIG=auto
oroption.generation_config=auto
. This is done to maintain backwards compatibility.Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Tested lmi, vllm, tensorrt-llm locally using llama-3.1-8b-instruct which contains a generation_config.json. I added some logging to validate the parameters were set in the sampling params