-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf: handle type embedding in DescrptSeA.serialize #3541
Labels
Comments
@wanghan-iapcm @iProzd We don't plan to support se_e2_a + type_embedding in dpmodel and pt. Do we plan to support self-serialization and deserialization in TF? |
I would say no, because se_e2_a + type_embedding is actually implemented by dpa-1 without attention layer. |
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this issue
Jun 6, 2024
Fix deepmodeling#3541. Signed-off-by: Jinzhe Zeng <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 11, 2024
Fix #3541. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new attribute `use_tebd` to enhance serialization handling based on input conditions. - **Tests** - Added new assertions to improve error handling in the test suite. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <[email protected]>
Closed in commit 73dab63 |
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this issue
Sep 18, 2024
) Fix deepmodeling#3541. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new attribute `use_tebd` to enhance serialization handling based on input conditions. - **Tests** - Added new assertions to improve error handling in the test suite. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
not sure how to handle type embedding - type embedding is not a model parameter,
but instead a part of the input data. Maybe the interface should be refactored...
Line: 1429
deepmd-kit//deepmd/tf/descriptor/se_a.py
Lines 1426 to 1436 in 76371ce
The text was updated successfully, but these errors were encountered: