Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf: handle type embedding in DescrptSeA.serialize #3541

Closed
github-actions bot opened this issue Mar 19, 2024 · 3 comments · Fixed by #3861
Closed

tf: handle type embedding in DescrptSeA.serialize #3541

github-actions bot opened this issue Mar 19, 2024 · 3 comments · Fixed by #3861

Comments

@github-actions
Copy link

not sure how to handle type embedding - type embedding is not a model parameter,
but instead a part of the input data. Maybe the interface should be refactored...

Line: 1429

raise NotImplementedError("spin is unsupported")
assert self.davg is not None
assert self.dstd is not None
# TODO: tf: handle type embedding in DescrptSeA.serialize
# not sure how to handle type embedding - type embedding is not a model parameter,
# but instead a part of the input data. Maybe the interface should be refactored...
return {
"@class": "Descriptor",
"type": "se_e2_a",
"@version": 1,

@njzjz
Copy link
Member

njzjz commented Jun 4, 2024

@wanghan-iapcm @iProzd We don't plan to support se_e2_a + type_embedding in dpmodel and pt. Do we plan to support self-serialization and deserialization in TF?

@wanghan-iapcm
Copy link
Collaborator

I would say no, because se_e2_a + type_embedding is actually implemented by dpa-1 without attention layer.

njzjz added a commit to njzjz/deepmd-kit that referenced this issue Jun 6, 2024
@njzjz njzjz linked a pull request Jun 6, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Jun 11, 2024
Fix #3541.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new attribute `use_tebd` to enhance serialization
handling based on input conditions.

- **Tests**
  - Added new assertions to improve error handling in the test suite.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link
Author

Closed in commit 73dab63

mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
)

Fix deepmodeling#3541.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new attribute `use_tebd` to enhance serialization
handling based on input conditions.

- **Tests**
  - Added new assertions to improve error handling in the test suite.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants