Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split Model and AtomicModel #3438

Merged
merged 9 commits into from
Mar 11, 2024

allow more positional arguments to make the tests happy

92ac826
Select commit
Loading
Failed to load commit list.
Merged

refactor: split Model and AtomicModel #3438

allow more positional arguments to make the tests happy
92ac826
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 11, 2024 in 0s

77.28% (+0.27%) compared to a9bcf41

View this Pull Request on Codecov

77.28% (+0.27%) compared to a9bcf41

Details

Codecov Report

Attention: Patch coverage is 92.30769% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 77.28%. Comparing base (a9bcf41) to head (92ac826).
Report is 7 commits behind head on devel.

❗ Current head 92ac826 differs from pull request most recent head 965f471. Consider uploading reports for the commit 965f471 to get more accurate results

Files Patch % Lines
deepmd/dpmodel/model/make_model.py 78.04% 9 Missing ⚠️
deepmd/pt/model/atomic_model/base_atomic_model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3438      +/-   ##
==========================================
+ Coverage   77.01%   77.28%   +0.27%     
==========================================
  Files         427      427              
  Lines       36790    36730      -60     
  Branches     1621     1621              
==========================================
+ Hits        28335    28388      +53     
+ Misses       7587     7474     -113     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.