pt: refactor loss #3569
Merged
pt: refactor loss #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3569 +/- ##
=======================================
Coverage 77.49% 77.50%
=======================================
Files 432 432
Lines 37164 37169 +5
Branches 1620 1620
=======================================
+ Hits 28801 28806 +5
Misses 7495 7495
Partials 868 868 ☔ View full report in Codecov by Sentry. |
|
Could you make an explanation why it needs to change the interface? |
I've updated the comment. |
njzjz
reviewed
Mar 20, 2024
njzjz
approved these changes
Mar 20, 2024
Chengqian-Zhang
approved these changes
Mar 20, 2024
wanghan-iapcm
approved these changes
Mar 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the loss interface to allow for a more flexible design.
It enables processing input tensors before feeding them into the model, such as denoising operations (fyi @Chengqian-Zhang ). Previously, this was done in the data loader, which was less intuitive and more confusing. Now, users can easily handle these tasks within the loss function itself, as demonstrated in similar implementations in uni-mol: https://github.com/dptech-corp/Uni-Mol/blob/main/unimol/unimol/losses/unimol.py#L20.