chore(dpmodel): move save_dp_model and load_dp_model to a seperated module

[njzjz]

Fix #3526.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates primarily involve restructuring the import and functionality related to model serialization in the Deep Potential (DP) software. Key changes include moving serialization functions to a new module, updating import paths in various files, and removing outdated or relocated functionalities from the network.py module. This reorganization enhances modularity and clarity in handling DP model serialization and deserialization.

Changes

Files	Summary of Changes
dpmodel.py, .../infer/deep_eval.py	Updated import paths from network to serialization.
.../utils/__init__.py	Moved load_dp_model, save_dp_model, traverse_model_dict to serialization module; removed PRECISION_DICT and DEFAULT_PRECISION.
.../utils/network.py	Removed unused imports and functions related to model traversal and serialization.
.../utils/serialization.py	Introduced new file handling DP model serialization, including saving, loading, and traversing model dictionaries.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 86b0bf8 and 3ae012b.

Files selected for processing (5)

• deepmd/backend/dpmodel.py (2 hunks)
• deepmd/dpmodel/infer/deep_eval.py (1 hunks)
• deepmd/dpmodel/utils/init.py (3 hunks)
• deepmd/dpmodel/utils/network.py (3 hunks)
• deepmd/dpmodel/utils/serialization.py (1 hunks)

Additional comments not posted (9)

deepmd/dpmodel/utils/__init__.py (2)

32-36: The import statements for load_dp_model, save_dp_model, and traverse_model_dict have been correctly updated to reflect their new location in the serialization module.

---

32-36: Ensure that the newly imported functions are correctly utilized wherever needed in the project to maintain functionality.

deepmd/backend/dpmodel.py (2)

103-103: The import statement for load_dp_model has been correctly updated to reflect its new location in the serialization module.

---

118-118: The import statement for save_dp_model has been correctly updated to reflect its new location in the serialization module.

deepmd/dpmodel/utils/serialization.py (3)

18-47: The function traverse_model_dict has been correctly implemented with appropriate type hints and documentation. It recursively traverses a model dictionary and applies a callback function to each variable.

---

70-97: The function save_dp_model correctly handles the saving of a DP model to a file using the HDF5 format. It uses the traverse_model_dict function to process the model dictionary before saving.

---

99-115: The function load_dp_model correctly handles the loading of a DP model from a file using the HDF5 format. It uses the traverse_model_dict function to reconstruct the model dictionary from the loaded data.

deepmd/dpmodel/infer/deep_eval.py (1)

27-27: The import statement for load_dp_model has been correctly updated to reflect its new location in the serialization module.

deepmd/dpmodel/utils/network.py (1)

Line range hint 1-1: Ensure that all references to the removed functions (traverse_model_dict, save_dp_model, load_dp_model) and imports (json, datetime) are updated throughout the project to avoid broken dependencies.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.89%. Comparing base (86b0bf8) to head (3ae012b).

Files	Patch %	Lines
deepmd/dpmodel/utils/serialization.py	94.73%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3701      +/-   ##
==========================================
- Coverage   81.89%   81.89%   -0.01%     
==========================================
  Files         508      509       +1     
  Lines       46585    46591       +6     
  Branches     2952     2952              
==========================================
+ Hits        38152    38156       +4     
- Misses       7540     7542       +2     
  Partials      893      893              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.