-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove --input_script
from dp test
#3800
Conversation
`--input_script` is not used in the current code. Also, mark `--rand-seed` and `--atomic` is supported in all backends. Signed-off-by: Jinzhe Zeng <[email protected]>
WalkthroughWalkthroughThe recent changes to Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3800 +/- ##
==========================================
- Coverage 82.58% 82.58% -0.01%
==========================================
Files 515 515
Lines 48806 48805 -1
Branches 2982 2983 +1
==========================================
- Hits 40308 40307 -1
Misses 7587 7587
Partials 911 911 ☔ View full report in Codecov by Sentry. |
`--input_script` is not used in the current code. Also, mark `--rand-seed` and `--atomic` is supported in all backends. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified help messages by removing backend-specific information for random seed and atomic label testing options. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <[email protected]>
--input_script
is not used in the current code.Also, mark
--rand-seed
and--atomic
is supported in all backends.Summary by CodeRabbit