Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable N804 and N805 #4024

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 25, 2024

Summary by CodeRabbit

  • New Features

    • Updated the linting tool to the latest version, enhancing code quality checks.
    • Introduced stricter naming conventions for method arguments in the linting rules.
  • Bug Fixes

    • Improved the functionality of instance and class methods, ensuring proper context usage.
  • Documentation

    • Updated the method signatures in tests to reflect best practices for class-level attributes.
  • Refactor

    • Standardized method signatures across multiple test classes to follow Python conventions.

Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Walkthrough

Walkthrough

The recent changes primarily involve updates to method signatures across various test classes, transitioning from instance methods to class methods by changing the first parameter from self to cls. Additionally, the version of the Ruff pre-commit hook in the configuration file has been updated, and new linting rules have been added to enhance code quality.

Changes

File(s) Change Summary
.pre-commit-config.yaml Updated Ruff version from v0.5.4 to v0.5.5.
deepmd/pt/model/task/ener.py Changed deserialize method from class method (cls) to instance method (self).
deepmd/utils/plugin.py Changed __call__ method from class method (cls) to instance method (self).
pyproject.toml Added linting rules "N804" and "N805" for stricter naming conventions in methods.
source/tests/tf/test_adjust_sel.py Changed setUpClass from self to cls.
source/tests/tf/test_finetune_se_atten.py Changed tearDownClass from self to cls.
source/tests/tf/test_model_compression_se_a.py Changed setUpClass and tearDownClass from self to cls in multiple test classes.
source/tests/tf/test_model_compression_se_a_ebd.py Changed setUpClass and tearDownClass from self to cls in multiple test classes.
source/tests/tf/test_model_compression_se_a_ebd_type_one_side.py Changed setUpClass and tearDownClass from self to cls.
source/tests/tf/test_model_compression_se_a_type_one_side_exclude_types.py Changed setUpClass from self to cls.
source/tests/tf/test_model_compression_se_atten.py Changed setUpClass and tearDownClass from self to cls in multiple test classes.
source/tests/tf/test_model_compression_se_r.py Changed setUpClass and tearDownClass from self to cls in multiple test classes.
source/tests/tf/test_model_compression_se_t.py Changed setUpClass from self to cls in multiple test classes.
source/tests/tf/test_transfer.py Changed setUpClass and tearDownClass from self to cls.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (5dd0062) to head (952ca94).
Report is 112 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #4024   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files         522      522           
  Lines       51010    51010           
  Branches     3023     3023           
=======================================
  Hits        42301    42301           
  Misses       7767     7767           
  Partials      942      942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jul 26, 2024
Merged via the queue into deepmodeling:devel with commit 561ff1b Jul 26, 2024
60 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated the linting tool to the latest version, enhancing code quality
checks.
- Introduced stricter naming conventions for method arguments in the
linting rules.

- **Bug Fixes**
- Improved the functionality of instance and class methods, ensuring
proper context usage.

- **Documentation**
- Updated the method signatures in tests to reflect best practices for
class-level attributes.

- **Refactor**
- Standardized method signatures across multiple test classes to follow
Python conventions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants