-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: enable N804 and N805 #4024
Conversation
Signed-off-by: Jinzhe Zeng <[email protected]>
WalkthroughWalkthroughThe recent changes primarily involve updates to method signatures across various test classes, transitioning from instance methods to class methods by changing the first parameter from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4024 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 522 522
Lines 51010 51010
Branches 3023 3023
=======================================
Hits 42301 42301
Misses 7767 7767
Partials 942 942 ☔ View full report in Codecov by Sentry. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the linting tool to the latest version, enhancing code quality checks. - Introduced stricter naming conventions for method arguments in the linting rules. - **Bug Fixes** - Improved the functionality of instance and class methods, ensuring proper context usage. - **Documentation** - Updated the method signatures in tests to reflect best practices for class-level attributes. - **Refactor** - Standardized method signatures across multiple test classes to follow Python conventions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <[email protected]>
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor