Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Make bias statistics complete for all elements #4496
base: devel
Are you sure you want to change the base?
(fix) Make bias statistics complete for all elements #4496
Changes from 89 commits
32da243
adf2315
4f6f63d
b9bac38
1db3408
543a318
ba72382
26f9a17
25a803c
dc64307
8f962b5
b88e7fc
f57498d
faeb7c5
725f1dd
ca7fc84
394cf04
05128d3
4828619
37ccce4
c9406e4
2224f61
ba12c2c
9fcee84
fe8579e
f004dff
11138ff
a4a97a3
88566fe
10e538d
203dc4e
bb9fbe1
6a65561
603aee9
1c103c4
4173040
e3a1c9b
533e95e
38dc18c
714c197
6713c1a
e42e38d
1c15cf0
33c716d
6d38b94
6bbced8
b462c97
0d7154c
0c7baa0
28d94af
87dcd66
5d33060
521e3a6
379d4ad
0dabf77
a23528c
0a97b54
49744ed
556a684
aa2633d
27999af
83b7f1d
817d2ec
234e461
93a748f
4a38f1d
78b2a10
6a5d169
26205d7
3ccb4b9
f669ac5
87de0e8
0939ef1
7ec779f
24d1386
708bc78
02f3f28
c648e9e
d36a24a
b6a483a
050dbaf
b00f8de
2f37dfe
47fe45b
98890c2
b9bdee5
a30053f
cfbc88a
73a20b0
0b29b05
85d4da3
0400233
c05ffb1
139f037
5e826bf
edf1d91
3887013
eb9f068
10ef768
c2dc7ef
8763165
d5596bf
9f389ad
0c76ad9
58647f3
4ce9cfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 84 in deepmd/pt/utils/stat.py
Codecov / codecov/patch
deepmd/pt/utils/stat.py#L82-L84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve error handling and data type validation.
The function silently handles unknown data types and lacks error handling for tensor operations.
📝 Committable suggestion
Check warning on line 131 in deepmd/pt/utils/stat.py
Codecov / codecov/patch
deepmd/pt/utils/stat.py#L131
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add validation and error handling for frame processing.
The function needs better validation and error handling:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for tensor operations.
The function lacks error handling for tensor operations which could fail.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add validation for dataset processing.
The main loop needs validation for empty datasets and error handling for tensor operations.
📝 Committable suggestion
Check warning on line 184 in deepmd/pt/utils/stat.py
Codecov / codecov/patch
deepmd/pt/utils/stat.py#L184
Check warning on line 188 in deepmd/pt/utils/stat.py
Codecov / codecov/patch
deepmd/pt/utils/stat.py#L188
Check warning on line 191 in deepmd/pt/utils/stat.py
Codecov / codecov/patch
deepmd/pt/utils/stat.py#L190-L191
Check warning on line 703 in deepmd/utils/data.py
Codecov / codecov/patch
deepmd/utils/data.py#L702-L703