Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPGEN with constrained structures #878

Closed
wants to merge 7 commits into from
Closed

DPGEN with constrained structures #878

wants to merge 7 commits into from

Conversation

ShaneLogic
Copy link

Add a new feature which can be used to generate constrained slab models automatically by specifying keywords "total_layers" and "fix_layers" in param.json (dpgen init_surf PARAM [MACHINE]), perturbating the atoms which is not fixed.

Co-Authored-By: Cyanbeacon [email protected]

ShaneLogic and others added 2 commits August 16, 2022 17:36
Add a new feature which can be used to generate constrained slab models automatically by specifying keywords "total_layers" and "fix_layers" in param.json (dpgen init_surf PARAM [MACHINE]), perturbating the atoms which is not fixed.

Co-Authored-By: Cyanbeacon <[email protected]>
@njzjz njzjz changed the base branch from master to devel August 16, 2022 18:21
@njzjz
Copy link
Member

njzjz commented Aug 16, 2022

Please resolve conflicts.

@wanghan-iapcm
Copy link
Contributor

Please check if I understood correctly: This PR add constrains to POSCARS, so one may conduct the constrained vasp AIMD simulation of surface structures.
In general, one does NOT need to do AIMD simulations for surface structures. Starting from a relatively good DP model for bulk structures, then explore the surface structures with DPMD is recommended, because it is much more efficient than AIMD.

@ShaneLogic
Copy link
Author

Please check if I understood correctly: This PR add constrains to POSCARS, so one may conduct the constrained vasp AIMD simulation of surface structures. In general, one does NOT need to do AIMD simulations for surface structures. Starting from a relatively good DP model for bulk structures, then explore the surface structures with DPMD is recommended, because it is much more efficient than AIMD.

Yes, your understanding is correct. This PR can generate constrained surface structures. The perturbations will only be added to the atoms which haven't been constrained. It seems that this PR is not necessary for training potential functions of surface models based on what you said.

@ShaneLogic
Copy link
Author

Please check if I understood correctly: This PR add constrains to POSCARS, so one may conduct the constrained vasp AIMD simulation of surface structures. In general, one does NOT need to do AIMD simulations for surface structures. Starting from a relatively good DP model for bulk structures, then explore the surface structures with DPMD is recommended, because it is much more efficient than AIMD.

Maybe It can be used to generate constrained surface models with perturbations for other explorations.

@@ -214,6 +223,7 @@ def create_disturbs_abacus_dev(fin, nfile, dmax=1.0, etmax=0.1, ofmt="abacus", d
stru_d['cells'] = cell_new

convert_mat = np.linalg.inv(cell).dot(cell_new)
convert_mat = np.linalg.inv(cell)*cell_new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug fixed #815 .

It seems that at some point you did not track the changes with git. I suspect there are other unwanted changes in this PR.

I suggest you checking out a new branch based on the latest devel branch, applying your changes on it and then resubmitting the PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for your suggestion. I will track the latest devel branch and resubmit the PR.

@ShaneLogic ShaneLogic closed this by deleting the head repository Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants