-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPGEN with constrained structures #878
Conversation
Add a new feature which can be used to generate constrained slab models automatically by specifying keywords "total_layers" and "fix_layers" in param.json (dpgen init_surf PARAM [MACHINE]), perturbating the atoms which is not fixed. Co-Authored-By: Cyanbeacon <[email protected]>
Please resolve conflicts. |
Please check if I understood correctly: This PR add constrains to POSCARS, so one may conduct the constrained vasp AIMD simulation of surface structures. |
Yes, your understanding is correct. This PR can generate constrained surface structures. The perturbations will only be added to the atoms which haven't been constrained. It seems that this PR is not necessary for training potential functions of surface models based on what you said. |
Maybe It can be used to generate constrained surface models with perturbations for other explorations. |
@@ -214,6 +223,7 @@ def create_disturbs_abacus_dev(fin, nfile, dmax=1.0, etmax=0.1, ofmt="abacus", d | |||
stru_d['cells'] = cell_new | |||
|
|||
convert_mat = np.linalg.inv(cell).dot(cell_new) | |||
convert_mat = np.linalg.inv(cell)*cell_new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bug fixed #815 .
It seems that at some point you did not track the changes with git. I suspect there are other unwanted changes in this PR.
I suggest you checking out a new branch based on the latest devel
branch, applying your changes on it and then resubmitting the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for your suggestion. I will track the latest devel branch and resubmit the PR.
Add a new feature which can be used to generate constrained slab models automatically by specifying keywords "total_layers" and "fix_layers" in param.json (dpgen init_surf PARAM [MACHINE]), perturbating the atoms which is not fixed.
Co-Authored-By: Cyanbeacon [email protected]