Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Download session headers #1429
feat: Download session headers #1429
Changes from all commits
d982f84
97b337a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last_id - file_id
вау а что это за математика?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В рамках одной сессии скачивания моделей мы имеей N файлов. last_id-file_id нужно чтобы нумеровать эти файлы от N-1 до 0. Получив dp-file-id == 0 мы понимаем, что это был последний файл в рамках данной сессии. С тем же успехом можно было добавить какой-нибудь хэдер вроде dp-last-session-file для последнего файла, но сделал обратный отсчёт.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ок, но я бы вынес в отдельную переменную, а то с ума сойдём потом
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Т.е. добавить
dp_file_id = last_id - file_id
, а в дикте'dp-file-id': str(dp_file_id)
? Не вижу смысла. Или ты про другую отдельную переменную?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
смысл был только в том, чтобы было понятное название у этой разности, но и так нормас