Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upper bound in transformers pin #5926

Closed
anakin87 opened this issue Sep 29, 2023 · 1 comment
Closed

Remove upper bound in transformers pin #5926

anakin87 opened this issue Sep 29, 2023 · 1 comment
Labels
2.x Related to Haystack v2.0 P2 Medium priority, add to the next sprint if no P1 available
Milestone
2.0.0

Comments

@anakin87
Copy link
Member

Currently, we are pinning a specific version of transformers.

We would like to remove the upper bound.

  • It seems like a bad practice, unless there are known compatibility issues
  • It forces us to frequently update the pin to allow new Transformers features.
@anakin87 anakin87 self-assigned this Sep 29, 2023
@anakin87 anakin87 mentioned this issue Sep 29, 2023
Closed
@anakin87
Copy link
Member Author

anakin87 commented Oct 2, 2023

It makes more sense for Haystack 2.x
(We don't want to break things in Haystack 1.x)

@anakin87 anakin87 added the 2.x Related to Haystack v2.0 label Oct 2, 2023
@anakin87 anakin87 removed their assignment Oct 2, 2023
@anakin87 anakin87 mentioned this issue Oct 5, 2023
Closed
@masci masci added the P2 Medium priority, add to the next sprint if no P1 available label Dec 11, 2023
@masci masci added this to the 2.0.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

chore: remove upper bound in transformers pin deepset-ai/haystack
2 participants
@masci @anakin87