Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers 4.34.x #5967

Closed
grantmwilliams opened this issue Oct 4, 2023 · 1 comment · Fixed by #5994
Closed

Transformers 4.34.x #5967

grantmwilliams opened this issue Oct 4, 2023 · 1 comment · Fixed by #5994
Labels
Contributions wanted! Looking for external contributions topic:dependencies

Comments

@grantmwilliams
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'd like to use the new OCR Nougat model in the 4.34 release of the hugging face transformers library.

Describe the solution you'd like
Is it possible to allow transformers>=4.32.1 in the requirements?

Describe alternatives you've considered
I've been forcing an override of the requirements and haven't noticed any related issues, but it would be nice to have official support.

@anakin87
Copy link
Member

anakin87 commented Oct 5, 2023

Hello, @grantmwilliams!

Your request is entirely reasonable.

Even if currently we don't want to totally remove the upper bound in transformers pin for Haystack 1.x,
it might make sense to pin transformers==4.34.0 and see if the tests pass or fail...

Feel free to open a PR, if you want...
In any case, I will label this issue as "Contributions wanted".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributions wanted! Looking for external contributions topic:dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants