-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable batch size and LR scheduler (moved to #7020) #5237
Variable batch size and LR scheduler (moved to #7020) #5237
Conversation
@bm-synth This is a completely new technique. For this kind of contribution, based on the guideline (https://github.com/microsoft/DeepSpeed/blob/master/CONTRIBUTING.md#new-feature-contribution-guidelines) we would need to first judge the value based on some formal evaluation (ideally an arxiv paper). |
@conglongli a question related to LR scheduling: the LR scheduler documentation says:
However this is not the case anymore I believe. If we look at
so |
@conglongli @mrwyattii I added some information to this PR in line with the new contributions page you sent. The logic for this PR is done, and the example works in the
Finally, this new Data Efficiency curriculum learning is based on files that need to be output beforehand by the
|
great work and waiting for this. |
thank you @npuichigo . For the time being, you can use this as in the example (first initialize deepspeed to get the deepspeed engine, then call |
@bm-synth First of all you still didn't provide any evidence of "variable batch size and LR scheduler helps improve model quality". But anyway I understand some users just want to do it so we can accept this PR. Regarding your question about curriculum learning: (1) Handling of multiple metrics is at https://github.com/microsoft/DeepSpeed/blob/aaaf8bc5e07535e263f83733f8905400bf6f5aca/deepspeed/runtime/data_pipeline/data_sampling/data_sampler.py#L184-L201 (2) Legacy curriculum learning does not reorder data, it works by truncating data to different lengths at user side code. |
Hi @bm-synth - thanks for your continued work on this PR, do you think it is ready to be merged? |
@loadams this can be merged. It was on hold for a while because I was looking for a better way for the user to interface with this, ie a clean way for the user to define in the deepspeed config which curriculum metric to use for this variable batch size module (this comment here ). I suggest we merge this now, and I'll work on the better interfacing in the next couple of weeks during the xmas break, in a different PR. thank you |
Thanks @bm-synth - we've resolved the issues in our CI and if the tests pass we can get this approved and merged, but there are test failures if you have time to take a look? Thanks. |
@loadams yes ill look into it next week. |
Thanks! Appreciate the continued work on this |
c52cd72
to
9061b2f
Compare
c51455c
to
9061b2f
Compare
…ort. (#6971) Nvidia GDS [does not support Windows](https://developer.nvidia.com/gpudirect-storage).
) Co-authored-by: Olatunji Ruwase <[email protected]> Co-authored-by: Logan Adams <[email protected]>
…ead of Raising Error (#6979) This pull request addresses an issue in setup_env_ranks where, under certain conditions, the function raises an error instead of setting the necessary MPI-related environment variables (LOCAL_RANK, RANK, and WORLD_SIZE). The intended behavior is to properly map Open MPI variables (OMPI_COMM_WORLD_*) to the variables expected by DeepSpeed/PyTorch, but the code currently raises an EnvironmentError if these Open MPI variables are not found. With this fix, setup_env_ranks will: - Correctly detect and map the required Open MPI environment variables. - Only raise an error if there is genuinely no valid way to obtain rank information from the environment (e.g., both Open MPI variables and any fallback mechanism are unavailable). Fix #6895 Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]>
…h 2.6) (#6982) Fixes #6984. The workflow was pulling the updated torch 2.6, which caused CI failures. This keeps us on torch 2.5 for now, since installing torchvision as a dependency later on was pulling torch 2.6 with it which was unintended. This PR also unsets NCCL_DEBUG to avoid a large print out in the case of any errors.
As discussed in [PR-6918](#6918), padding can occur on multiple ranks with large DP degrees. For example, with: - Flattened tensor size: 266240 - DP degree: 768 - Alignment: 1536 - Required padding: 1024 (1536 * 174 - 266240) - Per-rank partition size: 348 (1536 * 174 / 768) - The padding occurs on last three ranks. This PR removes the single-rank padding assumption for more general cases. --------- Co-authored-by: Sam Foreman <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]>
Fix #6772 --------- Co-authored-by: Logan Adams <[email protected]>
…#6967) - Issues with nv-sd updates, will follow up with a subsequent PR
NVIDIA Blackwell GPU generation has number 10. The SM code and architecture should be `100`, but the current code generates `1.`, because it expects a 2 characters string. This change modifies the logic to consider it as a string that contains a `.`, hence splits the string and uses the array of strings. Signed-off-by: Fabien Dupont <[email protected]>
Signed-off-by: Olatunji Ruwase <[email protected]> Signed-off-by: Logan Adams <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Co-authored-by: Fabien Dupont <[email protected]>
1. update intel oneAPI basekit to 2025.0 2. update torch/ipex/oneccl to 2.5
Same as [this PR](#6922). [affeb88](affeb88) I noticed the CI updated the DCO check recently. Using the suggested rebase method for sign-off would reintroduce many conflicts, so I opted for a squash merge with sign-off instead. thanks: ) Signed-off-by: inkcherry <[email protected]>
Those files have code that gets run when importing them, so in systems that doesn't support triton but have triton installed this causes issues. In general, I think it is better to import triton when it is installed and supported. Signed-off-by: Omar Elayan <[email protected]>
Signed-off-by: Logan Adams <[email protected]> Co-authored-by: Stas Bekman <[email protected]>
…G_SAMPLES_ORDER_DEFAULT
9061b2f
to
dbc5acb
Compare
moved to #7020. |
Note: PR closed and moved to #7020 .
Background and rationale
In many use cases, particularly LLMs, one is faced with inputs (sentences) of variable lengths. A common practice is to pack batches by token count (not a fixed batch size), ie by putting together sentences whose given metric (eg sequence lengths) will add up to an user-provided value. As an example, in Attention is all you need, section 5.1:
Dynamic batch sizes has been requested in DeepSpeed issue 1051, DeepSpeed issue 3455 , Pytorch Lightning issue 16914, huggingface issue 2647 and is available already in many libraries e.g. NVIDIA Triton and Meta FairSeq (implementation here ).
The immediate use case for this is when one needs to maximize GPU utilization. Moreover, this is particularly relevant for curriculum learning where a
BxTxE
(Batch x Time x Embedding) -shaped input should ideally have highB
and lowT
at the early curriculum steps (many short sentences packed together as a batch), and lowB
and highT
at the late steps (few long sentences in the batch). A dynamic sizeT
is already supported by Deepspeed, e.g. in the documentation for pipeline parallelism's reset_activation_shape():However, dynamic
B
is not supported. A dynamicB
would require an adequate increase/decrease of learning rate. This technique has been applied previously, and the two most common LR scaling algorithms have been described as:In practice, the user picks the total token count per batch as the metric that drives batching, instead of batching by sentence count. During runtime, the variable batch size is computed and the LR is adjusted respectively, based on the LR and batch size provided by the config.
Illustration of dynamic batch size, sequence length and LR
Imagine we picked a limit of
30
tokens per batch, and have set a referencelr=1e-3
for atrain_batch_size=2
(in the deepspeed config). The batching algorithm for curriculum may pack the data into batches of short sentences (left) at the early stages, and batches of long sentences (right) as later stages, e.g.:Above, we collected samples until we filled up the batch with at most 30 tokens. The batch sizes (number of samples) became then
10
and4
on the left and right examples, respectively. Using the linear scaling rule, the LR for those batches become5e-3
and2e-3
.Pipeline parallelism
Pipeline parallelism requires the same batch size and same sequence length across all micro-batches in a batch, as the activation sizes must be fixed between gradient accumulation steps. Between batches, these may change, and long as
engine.reset_activation_shape()
is called so that the new shapes are communicated on the first gradient accumulation step in the batch. Enforcing similarBxTxE
between batches may lead to smaller micro-batches. As an example, below we can see an illustration of a 2-node 2-gradient-accumulation-step (ie 4 micro-batches) batching for the same dataset, when preparing data for the regular DDP (left) and for the pipeline parallelism use cases (right):We can see that the pipeline use case (right) has the same
BxTxE
shape across all the 4 micro-batches in the same batch, and in order to respect that, it packs less samples in the batch, when compared to the standard use case (left hand size)Attention Head
For an input of size
BxTxE
the attention has a shape ofTxT
for a mask of fixed size across samples of same size, orBxTxT
for a different mask per sample (when samples have different sizes, as in the dataset above). This 3D attention matrix can be illustrated for the DDP microbatch 1 (picture above top-left, 4 sentences) as:Note the memory savings: the attention head has a size of
BxTxT
, i.e. a linear memory dependency on the batch sizeB
and quadratic memory dependency on the largest sequence lengthT
in the (micro-) batch. Thus, supporting a dynamic sizeT
allows for an increase ofB
.PR overview
This PRs implements dynamic batching and LR scaling. The dataloader and LR scheduler necessary can be retrieved by calling
get_dataloader_and_lr_scheduler_for_variable_batch_size
. A small explanation of that function follows:scale_lr
;batch_by_size
.True
the following parameters:required_microbatches_of_same_sizes
that will force theB
dimension to be the same across all gradient accumulation steps of all dataloaders on a batch;required_microbatches_of_same_lengths
that will force theT
dimension to be the same across all gradient accumulation steps. Works by calling the user-providedsample_padding_fn(sentence, len)
that pads a given sentence to the argument length;batch_by_size
returnsmicrobatch_sample_ids
(the list of sample ids per micro-batch),batch_sizes
(the size of effective batch sizes, andbatch_max_seqlens
(longest sequence across all microbatches in a batch)dataloader_for_variable_batch_size
relies onmicrobatch_sample_ids
and will iterate/collate/pad samples for every batch and return a dataloader that iterates the final (variable-size) batches;lr_scheduler_for_variable_batch_size
relies onbatch_sizes
to compute the learning rate for each effective batch, taking into account the batch size and LR in the config file, and scaling the LR based on the size of each effective batch, and the scaling rule mentioned above (Linear, Square root, etc).lr_scheduler
returned that will either accept either:Optimizer
that will scale the learning rates (in param groups) at every batch, orLRScheduler
, that in this case will first get the learning rate from the scheduler and then scale it accordingly.Example
An example for the use case with and without pipelining is provided in
deepspeed/runtime/data_pipeline/data_sampling/variable_batch_size_and_lr_example.py
. The example shows an attention head with attention of variable-sizedBxTxT
per batch, followed by a fixed size feed forward network. These are the main blocks on a Large Language Model. The feed-forward (or linear layer) that follows the attention head requires a constant input size, equivalent to the largest sentence in the whole dataset, so the output of the attention must be padded (seefeedforward: needs to convert BxTxE to BxMxE by padding extra tokens
in the code).