Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ignoreDuplicates could use some improvements #524

Closed
dpryan79 opened this issue May 4, 2017 · 1 comment
Closed

--ignoreDuplicates could use some improvements #524

dpryan79 opened this issue May 4, 2017 · 1 comment
Assignees

Comments

@dpryan79
Copy link
Collaborator

dpryan79 commented May 4, 2017

@thomasmanke happened to notice that deepTools estimates for the number of duplicates are always significantly below those produced by picard. While there are a number of differences between the two algorithms (picard doesn't always get it right), one big difference is that deepTools only remembers the last alignment seen. That's not an issue if one uses picard to sort alignments, since they're then sorted by pos and then mpos, but that's not the case for samtools sort, which just sorts by pos. I already implemented an improved method here, but I'm not going to put that sort of change in a bug fix release, which is what the current develop branch will quickly become.

@dpryan79 dpryan79 self-assigned this May 4, 2017
@dpryan79 dpryan79 added this to the 2.6.0 milestone May 4, 2017
@dpryan79
Copy link
Collaborator Author

dpryan79 commented Jul 7, 2017

This is now implemented in the develop branch.

@dpryan79 dpryan79 closed this as completed Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant